Benjamin

Results 23 comments of Benjamin

Hey, I hope this is correct: https://github.com/rectorphp/rector-symfony/pull/589 Wasn't sure if that will work, since IDE is complaining about same class names in the same file, but apparently we don't want...

Yeah, it's a little confusing for me, I was cleaning a project that was using Listeners and Rector wanted to convert to EventSubscriber, I wondered why I did some digging...

> single rule should handle single purpose, on this case, should be skipped if the `AsEventSubscriber` present. > > New rule should be exists for new conversion. It's not `AsEventSubscriber`...

Thanks for your answer, I am still not sure about that. Should that Rule really be dropped from the CODE_QUALITY? The idea of it was to ensure people don't use...

Hey, I so much love this bundle - Awesome work! I found it a while back and kept an eye on it, because I am eager to use it. Sadly...

Thank you so much for your answer, that is actually not what I wanted to hear :D I digged into the docs and this package is already really amazing, so...

> Isn't the abstraction with ProxyQueryInterface enough? We're not tied to any specific data source, and Doctrine is completely optional (and will be extracted to separate bundle soon). As of...

> If I understand what you mean correctly, in your case, you cannot apply the filters individually, but rather collect the filtration data and apply it only once. I'm thinking...