Jean Cvllr

Results 8 comments of Jean Cvllr

I posted a fix to a similar schema validation error in #14338 Based on these two answers on StackOverflow also related to schema validation errors : - https://stackoverflow.com/q/56542518/8245387 - https://stackoverflow.com/a/56537342/8245387...

Same problem, with a sample Hardhat setup, and I do not get the gas cost per unit test. **with Hardhat** ❌ ![image](https://user-images.githubusercontent.com/31145285/181293538-ebe7eef2-b855-4e38-b238-1c0559aad4e4.png) However, with truffle, I do get the gas...

`event RenounceOwnershipInitiated(...)` There should be as well a deadline for renouncing ownership. ``` // renounceOwnership(...). // ---------------------> timeline to confirm block n + 50 ---------------------------------------------> block n + 150 ------------------>...

@frozeman adding this as a comment for clarity (as it is mentioned in the first comment of the issue. We agreed on calling the same function `renounceOwnership(...)` twice ✅ (no...

@Amxx going back on this topic, I do still think it would make sense to add ERC165 by default in ERC20, so to advocate this as a best practice. The...

Having support for custom error in Typechain would be indeed very useful. Would be great if someone could re-trigger the CI :)

One thing mentioned by @frozeman is that for certain schema, like when valueType is a tuple with two `bytes` inside as `(bytes,bytes)`. In such case, the valueContent, should tell. but...