Loïc Mangeonjean

Results 159 comments of Loïc Mangeonjean

Since monaco-editor is imported directly, I think it's a good idea to have it in the package.json

Yep, exactly what I meant, you can do import `vscode` before starting your first editor to prevent the error

Simply importing `vscode` should do the trick, importing `monaco-languageclient` should work as well We use an alias from `vscode` to `@CodinGame/monaco-vscode-api`

It now relies on the NotificationService from monaco/vscode. When creating your first editor, you can overwrite it: ```typescript import { INotificationService } from 'vscode/services' const EventNone: monaco.IEvent = () =>...

Are you sure your service is used? The services can only be overriden once

Oh your error in uncaught, it probably mean you are the one calling `stop` without handling the promise error

Can you follow the stack to find where the stop() method is called? The only place where `stop` is called from the lib itself is when the initialization fails it...

Is there anything blocking this change from being merged? @hediet maybe?

You'll need to hack plenty of stuff to achieve exactly what you describe, I'm not sure it's even doable but it's sure it's very hard Your best chance is to...

The only way is by hacking the folding feature, you can have a look at https://github.com/CodinGame/monaco-editor-wrapper/blob/main/src/tools.ts you can use the hideCodeWithoutDecoration function: ```typescript editor.createDecorationsCollection().set([{ range: , options: { className: 'displayed',...