Christopher Jellen

Results 12 comments of Christopher Jellen

Preliminary comments for this PR: * the main changes are to `pathfinder_svc` and `pathfinder_gui`, with some small, mostly-boilerplate changes made to `c_host.py`. Comments and minor changes were added to the...

@heatonk When executing these tests on your `v2-algo` branch, pytest is throwing `ModuleNotFoundError: No module named 'plugins'`. Do you see the same on your end or do the tests execute...

The method-level changes look great, still two issues to resolve before this PR can be fully reviewed and merged: 1. The spacing issue in `c_host.py` and elsewhere is still present...

This looks great, very clean and easy to follow (although your explanations helped tremendously in that regard). I have a bit more local testing to do, the debug function is...

The guided planner performs well under its core use case. The attack graph implementation looks great for cases in which we can interpret pre/post conditions from facts, or leverage the...

Just tested on a clean caldera and noticed that we don't have `networkx` documented as a requirement. We could add a `requirements.txt` to `stockpile`, as we do for some other...

Hello @Cy-Beard , thank you for your patience while we debugged this issue. If you re-pull the latest and rebuild the image after adding the `--insecure` flag (and preferably `--log...

Thank you foe the heads up @tomsail ; I will look into migrating the [ndbc API package](https://github.com/cdjellen/ndbc-api) without changing the API surface. Hopefully this will help determine if there is...

Thank you so much for your thorough review @ks905383; the "modes" that the API supports map directly to the [data modalities outlined in the web data guide](https://www.ndbc.noaa.gov/docs/ndbc_web_data_guide.pdf). While I believe...

Thank you @ks905383 ! I've updated the README with `conda` instructions; great point there as this was a relatively recent change. With respect to python 3.13 support, I've spent some...