Christopher Speir

Results 7 comments of Christopher Speir

Should I run `cargo collect-metadata` before pushing the commit? I ran it for the latest commit pushed, which alphabetized `lint_configuration.md` as well as the auto-generated configuration options in `CHANGELOG.md`.

Thank you for reviewing the PR. It should include the changes you requested. I went ahead and squashed and merged the changes with the latest from master.

In addition to fixing the merge conflicts, I moved `is_from_proc_macro` test to last since it seems to be the most expensive. Also made a minor change to a string literal...

I guess `missing_abi` already checks for this, and therefore this PR isn't needed. There is one difference, this lint emits a diagnostic with a suggestion. I don't believe `missing_abi` does.