C.A.M. Gerlach

Results 453 comments of C.A.M. Gerlach

I ran them; also, for WIP PRs, you can use GitHub's built-in "Draft" feature rather than manually adding a "WiP" to the title. Review in work now.

Just FYI, with GitHub's suggestion feature, you can just go to the `Files` tab, press `Add to batch` on the suggestions you want to apply and then commit them with...

> Don't worry about not having a perfect score. The one issue to note with that is a common use case of `pyroma` is with pre-commit and CIs (as, e.g....

(this was what I was imprecisely referring to with > This can be partially mitigated by manually configuring the hook invocation to use a lower fail threshold, but given the...

Yeah, this basically comes back to the same naming issues we've discussed previously, which will hopefully be more fully resolved in future versions. > Remove the fetch_classifiers hack and move...

(FYI, the current canonical spec for the [project] table is the [Declaring project metadata spec](https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#authors-maintainers) on the [PyPA specs section of the PyPUG](https://packaging.python.org/en/latest/specifications/)). While the PEP doesn't specify, this is...

> IIRC reading metadata from pyproject.toml isn't supported yet. > The rest of the metadata gets read from the pyproject.toml without issue. Actually, Pyroma doesn't read metadata from the `pyproject.toml`,...

Hey, thanks for the ping. IMO, the best way to implement support would be to read PEP 621-standardized metadata from the pyproject.toml, which shouldn't require too many code changes and...

It would be good for @WouterVH or someone else using Poetry to test to confirm there aren't any other issues, but yes, PEP 517 support is what is needed here;...

Seems like there still is one issue with PEP 517 support for arbitrary backends that I discovered thanks to the new test in #78 , but thankfully its not only...