pyroma
pyroma copied to clipboard
regebro
Support checking the Requires-Python metadata
First-time contributors need a maintainer to approve running workflows @CAM-Gerlach / @regebro your approval is needed to run CI jobs.
I ran them; also, for WIP PRs, you can use GitHub's built-in "Draft" feature rather than manually adding a "WiP" to the title. Review in work now.
It is a good point that they should state the sameish thing.
On Thu, Aug 25, 2022 at 9:49 AM David Andreoletti @.***> wrote:
@.**** commented on this pull request.
In pyroma/testdata/complete/setup.py https://github.com/regebro/pyroma/pull/83#discussion_r954619767:
@@ -10,6 +10,7 @@ version=version, description="This is a test package for pyroma.", long_description=long_description,
- python_requires=">=2.6",
Side note: we are not the only ones to bump into the classifier for humans , python_requires for machine https://github.com/badges/shields/issues/5551.
— Reply to this email directly, view it on GitHub https://github.com/regebro/pyroma/pull/83#discussion_r954619767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGIK5BMO3XDTUGWCT5YB4TV24QSLANCNFSM57O4IOFA . You are receiving this because you were mentioned.Message ID: @.***>
this is really an entirely separate, independent check.
You are right. The initial version tried not to break compatibility with current release: package without a "python_requires" are well "package" from pyroma's point of view.
With the new version (independent test added), then most test fails with 'You should specify what Python version ... with 'python_requires=...''. Tests have been fixed but pyroma users will have to add "python_requires" to their package description file starting from the next release.
@CAM-Gerlach Updates provided.
Once approved, should I squash the PR's commits or will you merge-squash it ?
Just FYI, with GitHub's suggestion feature, you can just go to the Files tab, press Add to batch on the suggestions you want to apply and then commit them with the Commit button, which then commits the suggestion the reviewer is requesting and automatically resolves the comment for you. This saves you a lot of work making the change manually, and is also a lot less for reviewers to confirm the requested changes were made and see what other modifications were done.
Once approved, should I squash the PR's commits or will you merge-squash it?
That's up to @regebro