Sebastian Thiel
Sebastian Thiel
It took me a while to realize that this issue is most likely related to the introduction of tempfile here: https://github.com/gitbutlerapp/gitbutler/commit/6665bc92898ba139114278dbc20c72ef466ec4cd . There seem to be two writes in short...
Thanks so much for this investigation - very helpful, and much appreciated. It seems like the semantics of `perist()` differ depending on the platform, as it's atomic on Unix -...
> Re: the mingw code, it seems to account for some cases where it doesn't have permissions to modify the file. If it does, but still gets an access denied...
Just as a summary, this issue was raised when atomic-writes were first introduced, in order to prevent half-written files to corrupt the GB repository. Thus, getting this to work on...
After talking to @anaisbetts I also learned that there is a `FILE_SHARE_DELETE` flag which should allow the deletion of files that are currently opened. So if `mv a.lock a` just...
Finally I was able to create the test-build which contains some `tempfile` modifications which *might* just make this work. It will run on x86-64 Windows systems. [gitbutler-tauri-2024-05-25-01.exe.zip](https://github.com/gitbutlerapp/gitbutler/files/15443687/gitbutler-tauri-2024-05-25-01.exe.zip) ### How this...
> we want to _solve_ locking bugs, not hide them! I meant it as a test to see if Defender is a common reason for these errors, and not to...
Thanks everyone for your help with testing this, and for bearing with us. I have compiled another executable based on 0.12.2 (c6b22a727bef312708a1d0afe68ed756c264e408 specifically) which should in theory have less trouble...
Thanks for the detailed account of what happens here, it's much appreciated and very useful! It seems there are two different kinds of errors here - one is about failure...
Thanks for reporting! I don't think anything change in that department, but I have added [more logging](https://github.com/gitbutlerapp/gitbutler/pull/4806) to make clear which executable it would try to use. While this trickles...