Sebastian Thiel

Is this PR still active?

Thanks for bringing this up! I also would love to get rid of all `unsafe`. In this case, it's used to allow access to a size-optimized vec of items that...

Thanks for chiming in - I like your standard as it's easy to follow and thus hopefully just as easy to apply. Trying just that, I created #1233. > *...

I think the main culprit is that `ItemSliceMut` is really a way to access `T: Send` items mutably from multiple threads, and there are no guardrails at all. There was...

I wish this could be reflected somehow, after all the `T` that's actually stored is `Send + Sync`, and it was never the intention to allow `T` that are `&Type`...

This definitely compiles even though it shouldn't: ```patch diff --git a/gix-pack/src/cache/delta/traverse/util.rs b/gix-pack/src/cache/delta/traverse/util.rs index 95789b50b..79602ada1 100644 --- a/gix-pack/src/cache/delta/traverse/util.rs +++ b/gix-pack/src/cache/delta/traverse/util.rs @@ -59,3 +59,18 @@ unsafe impl Send for ItemSliceSync where T:...

I dug in and added this chunk of text. In summary, this is for handling a special case where ref-delta entries point to their base by id which is in...

As of Version 0.11.3 (20240419.070253), to me personally the "Add Project" experience is still similar to what you are describing and something I hope will be improved. However, for authentication/fetch/push,...

Thanks a lot for bringing this up! I will be sure to test it on MacOS as proposed once it's changed to non-draft.

Yes, I agree! I will see to add support for whatever that is - it's not pack V3 I think as that would fail gracefully elsewhere. It's surprising that older...