Sebastian Thiel
Sebastian Thiel
It's going to be good, thanks again for all your work on this! My greatest hope is that you keep having fun :). > To do that correctly, they'd need...
That's great! Could this be reproduced with a baseline test, maybe also producing versions with Meyers and Histogram respectively? It's notable that the diff takes newlines into account, and it's...
Great, thanks, I will take a closer look later. > I’ve also moved most of the setup out of `blame_file`. Is that what you had in mind? There’s still dependencies...
I took a closer look and have factored out the remaining bits that can be removed in a straightforward fashion. Maybe that's mostly it already. The test-case is wonderful by...
I think cry for help it is, @pascalkuthe 😅. After applying this patch: ```patch diff --git a/gix-blame/src/lib.rs b/gix-blame/src/lib.rs index a737965a6..c4ec75cfa 100644 --- a/gix-blame/src/lib.rs +++ b/gix-blame/src/lib.rs @@ -815,6 +815,13 @@ pub...
> at first glance this looks like the slider problem (https://github.com/mhagger/diff-slider-tools/blob/master/README.md). Thanks so much for sharing! I also do remember now that you already shared this with me, probably in...
Thanks for the update :). Generally I am happy to follow your preference when it comes to merging, so what follows is just my preference, which isn't the deciding factor...
Yes, that's what the test is trying to assert. New crates are typically gated, while it's easy to know which capability is powered by which plumbing crate, at least in...
My approach would be to put `gix-blame` behind a feature toggle in `gix`, assuming that it is made available there with a higher-level API. A recent example for this could...
Thanks a lot for bringing this up and for the proposition of viable avenues for improvement. I think this case perfectly describes the underlying of a misleading API too, where...