Kevin Lloyd Bernal

Results 8 comments of Kevin Lloyd Bernal

Hello everyone! 👋 I've created a POC in how we could potentially integrate such functionality into DVC _(based on all of the discussion here so far)_. The flow would essentially...

Thanks for unearthing this @kmike as I totally forgot about it 😅 . I've added tests and rebased the PR to master.

I'm also slightly in favor to go with Approach 1 since the API is quite direct. The idea of simply specifying the item that you want rather than the PageObject...

I'm inclined with having `item_cls_fields=False` as the default because it throws off an explicit error for undefined fields. However, let's explore this in the perspective of POs as simply "filling...

Hi @victor-torres , thanks for taking the time on explaining this feature! This actually opens up a lot of opportunities for us, like having a neat way to get the...

Thanks for all the help everyone! I was able to make it work using the providers. 🎉 I attached the full reproducible code below for posterity. However, I tried to...

I think this is ready for a proper review since the new API has been more or less validated in **scrapy-poet**'s test cases: https://github.com/scrapinghub/scrapy-poet/pull/88/files#diff-a5ce1f1bde36b639be5be17fed1ed35ffb018c1fefcf4544c0e3fac120ca58eb

> I think this will show deprecation warnings for all requests with dont_filter=True, even ones that use it to skip the dupefilter? Yes but only once as https://docs.python.org/3/library/warnings.html states: >...