Henrik Gaßmann comments

Results 102 comments of


                                            Henrik Gaßmann

sqlite: better-sqlite3 shouldn't be the default driver (as is), nor be used if more than one sqlite instance or other DBs are also used

> This makes it a poor fit for a default driver of kysely currently. > […] > In particular when the project: > […] > * have many small queries...

Proposal: Simplify/improve Hash::PartialEq impls and remove constant_time_eq crate

> As far as I can tell, constant_time_eq doesn't do anything special, but if there's a specific quality of it's comparison that blake3 relies on Given that the description of...

Add `ConstantTimeEq` support for `Hash`

@AaronFeickert there you go. Feel free to ping me if you need something else 🙂

Add `ConstantTimeEq` support for `Hash`

I am in favor of merging, but the decision is not up to me.

Hash should serialize as byte string

Two notes from someone who wrote a CBOR serialization library in the past: * Use `0xfe` / `254` for byte test data instead of `0xff` / `255` due to the...

build(CMake): support running tests with ctest

I believe this has been superseeded by the TBB PR

Build for Windows 7

note that MS is gutting support for Win7, Win8 and Win8.1 in the next MSVC iteration https://github.com/microsoft/STL/issues/4858

[fmt] update to v11.2.0

btw. it seems like eigen will finally cut a new release soonish: * https://gitlab.com/libeigen/eigen/-/merge_requests/1897 * https://gitlab.com/libeigen/eigen/-/issues/2907

Failed to build c code with CMake on Windows

I will take a [closer] look tomorrow. EDIT: It seems like MSVC needs special treatment w.r.t. `CMAKE_SYSTEM_PROCESSOR` until the CMake folks decide on a path forward [[1]][[2]]. Specifically we need...

Work around msvc bug

Thanks for the report! I've upvoted the DevCom ticket. However, I think we should hold back on merging the fix until the MSVC v17.12 release is imminent as the MSVC...