Kim Burgestrand
Kim Burgestrand
FYI I force-pushed, because I added tests to each commit.
I've noticed that certain commands (e.g. `app exec -i`, `logs -f`) doesn't go through SSHKit, so this change isn't complete.
~~For now this got me far enough to notice there's more to it to get it to work for a few specific commands.~~ ~~I don't know _which_ parts need to...
> Is the issue time or other resources? [...] Motivation and time expenditure! I've been experimenting with Kamal for future projects, but paid client work got in between and I'm...
This is probably my fastest reply ever. Luckily we're using it in a very limited capacity, a single call-site: https://github.com/varvet/pundit/blob/54cc64e45a3e4c606f555f05ce740e72c4f00946/lib/pundit/authorization.rb#L232-L238 Pundit should definitely support Rails 8. Will ponder some more!
So if I understand correctly, behaviour doesn't change in an upgrade to Rails 8. It's just that `expect` is a new way of doing things. However, `expect` has an entirely...
Two things important to me: - Backwards-compatibility. We should not break it. - A new way needs to be battle-tested. We can achieve backwards-compatibility by _adding_ to the API surface,...
Kinda related to #742
I think my main worry is how _Pundit_ integrates with the API, i.e. how we hook up all the helper methods and how they relate to each other. `pundit_params_for(record)` exists...
Hi, thanks for the pull request! I adjusted the PR description to use the PR template we've got going on. This change would need a CHANGELOG entry. On another note,...