Kim Burgestrand
Kim Burgestrand
Sorry to beat a dead horse but… 😅 :trollface:
Can still be better.
Hi! Thanks for the PR! I personally like this and believe it makes sense. I'd like to get another set of eyes on this, e.g. by @dgmstuart before merging.
Hi again! Due to some recent changes (not yet released but available in `main`) the `record` is no longer passed as an array, so hopefully _most_ of this problem is...
I believe the reasoning in this issue makes sense, and agree with most everything except for possibly the issue with the implementation as mentioned in https://github.com/varvet/pundit/pull/655#issuecomment-895822291 Either way, as mentioned...
Taking a look at some old issues. Commenting for documentation's sake. This PR is still relevant, even though the underlying code has changed. We're still not including the policy name...
#647 is also related to this!
Hi! Sorry, you never received a reply. What I'm missing here is an actual test of behaviour that this change fixes. I'm not against the change, but I don't understand...
FYI this came up again with #785, so I suggested moving that into here.
See https://github.com/varvet/pundit/pull/749#issuecomment-1463693064