Bukhtawar Khan

Results 58 comments of Bukhtawar Khan

> I'm basically rephrasing a question above, but is the intent here to move the exact functionality of the existing plugin into core, so that existing users would get the...

Async search uses the same `SEARCH` threadpool for handling actual searches, however for overall management related activities like clean up expired stored responses, timer for handling timeouts, we use another...

We would want to reuse code as much as possible, minimize code duplication. It doesn't seem optimal to reimplement(except for what's needed to move to core) or maintain redundant pieces...

@nknize Since this is a plugin the core changes are minimal. The plumbing work around search progress listeners to support async search largely sits in core already. The plugin majorly...

Good to see this discussion, resurrected and some items getting prioritised. Thanks @andrross @sohami @mch2 From a search freshness perspective there was some thought to decouple remote uploads from refresh...

``` org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=snapshot.status/10_basic/Get missing snapshot status succeeds when ignoreUnavailable is true} org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=snapshot.clone/10_basic/Clone a snapshot} org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=snapshot.get/10_basic/Get snapshot info when verbose is false} org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_alias/10_basic/Get aliases via /_all/_alias/} org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/300_pipeline/Max...

My two cents lets start with nextToken and avoid a previous token since it's quite possible to see inconsistent results when user performs prev and then next when the backing...

Thanks @shwetathareja do we also want to consider versioning using custom headers For instance we can have curl -H "Accepts-version:2.0" _cat/indices. The benefit of using this is it doesn't clutter...

> Thanks @Bukhtawar . I did think about header for versioning, just that it is not so obvious or visible. Also for certain APIs (like here where next_token will be...

Thanks @rishabhmaurya for the proposal. Still, catching up, so could be wrong but I am assuming we aren't changing data formats and this proposal aims at joining the data fetched...