Bruno Levy
Bruno Levy
All lights green !
Got a crash on mac with `compute_CSG example_018.csg`, Debug, Gargantua, [this build](https://github.com/BrunoLevy/geogram/actions/runs/8435488735) This one will be difficult to catch because it is not reproducible (re-launching the job did not re-trigger...
Added a stacktrace in the signal handler Problem seems to occur in `simplify_coplanar_facets()`, in the phase that runs in parallel, that uses a `CoplanarFacets` object, that creates some attributes. Maybe...
It seems that `AttributeStore::notify()` mises a spinlock acquire/release.
Seems to be fixed by acquiring/releasing the spinlock in `AttributeStore::notify()`. Before closing the issue, I need to make sure there are no wrong concurrent accesses to the mesh in `simplify_coplanar_facets`,...
Added `MeshFacets::reserve()` function called at the beginning of `simplify_coplanar_facets()`
Seems to be fixed (summary): - solved concurrency issue in `AttributeStore` notify mechanism - pre-allocating upper bound of number of facets in `simplify_coplanar_facets()` If the problem reappears: - double check...
Hi there ! Wow, impressive work and documentation ! It's fantastic ! (sorry for beeing not reactive at all, I was completely swamped in many projects + administrative tasks). About...
(I'm sorry I am a bit slow to answer, need to finish a batch of changes / bugfixes then I'll come back to you right after).
I have in mind two things: - for spinlocks, replace them with std::atomic. Do you have an experience with it ? I don't know whether it is efficiently implemented in...