Michael McLean

@reisenberger I've committed all the tweaks to the above, and the core change for the Adv. CB. Shall I raise that as a new bnanch and new PR based off...

Heya, sorry for the delay. work got a little hectic as a project drew to a close. Back on this now. Have just pushed the aforementioned review markups and Implementation...

@reisenberger I've completed the rote changes (adding the new options to all the syntaxes, and extending all the tests to run with static duration and also "dynamic" duration (i.e. where...

EDIT: New status update below, as of 31/1/2020 Remaining actions: * @reisenberger to re-review original markups (currently pushed) * @reisenberger to shout if/when you want the rote changes pushed for...

Heya, Had a proper look at the tests, and I don't think the tests for dynamic duration are too complex. As a precursor, I'm going to factor out the most...

>I don't think we need to do this. Where a circuit-breaker tests is testing something entirely orthogonal to the changes you have made (that it breaks on the right exceptions;...

> It looks like most of the existing tests on circuit-break duration are in a section marked Circuit-breaker open->half-open->open/closed tests. > [snip] > For these existing tests, we would want...

>There is also a separate test in the callback-delegates section about the break-duration being passed to the callback delegate: Should_call_onbreak_with_the_correct_timespan. Ah hah! Yes, that's the sort of thing I think...

LMK about removing the duplication of existing tests, and then I'll implement the extensions and new tests.

Rote changes to other syntaxes pushed. As previously the first commit (`1974636a`) is duplicating the existing methods verbatim, so that the second commit (`fc80d1368`) has the interesting diffs. So you...