Michael McLean

Note that I'm interested in picking this task up and submitting a PR. One concern I have is that we'd probably want to modify all 5 "constructors" for both Sync...

Design choice, please! There's a complication with implementing this, because there are 2 diffferent 'kinds' or 'places' of CB duration. There's the obvious version, where requests are resolving very quickly,...

The other point that has come up is that the "throw if TimeSpan is non-positive" constraint is more natural to evaluate at Inner-Action-Runtime, rather than Policy-Setup-Time. Note that a negative...

@reisenberger ☝️

See PR ☝️ :) Not quite "finished", there's a bunch of Tedious "and now do it all again 7 times" stuff to do, and some better tests to write, but...

Note that you may well find it easier to review this commit-by-commit. The first commit is entirely mechanical copy-pasting; the ones after that are more interesting.

👍 Enjoy your break. Thanks for the expectation-setting :)

EDIT: New status update below, as of 20/1/2020 Cool, so status update: I've applied almost all the review markups, locally. Tasks still outstanding: * (@reisenberger) Sign-off on general review discussions....

> (@reisenberger + @Brondahl) Decide on what we're going to do to the Advanced Circuit Breaker. So I see ... 3? ... options. - Do nothing. - Assert that the...

👍 Will update from the small comments above and push. Then start the rote changes. Will probably hold off writing completely new unit tests, and discuss them with you before...