Ruben Bridgewater
Ruben Bridgewater
We can also add a check that looks `util.types.isNativeError()`. That is how `assert` itself checks for errors next to instanceof.
@ulitink is this ready to review? Or is this still work in progress?
It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood...
I noticed late that there's actually a test added in https://github.com/nodejs/node/pull/635 that checks that __inherited__ properties are checked as well as fs option (this will likely not work everywhere but...
Rebased due to conflicts. @jasnell @devnexen @lpinca this is semver-major, which was not known while you gave your LG. It would be great if you could confirm/update your LG.
@mcollina inherited object properties won't be accepted as options anymore. So if you do e.g.: `Object.create({ encoding: 'utf8' })`, `encoding` won't be detected anymore and it's just handled as empty...
@mcollina the question is if we want to officially support inherited properties or not. I was quite surprised when I noticed the failure that we allowed something like that. AFAIK...
@mscdex sorry I made a mistake while looking at this earlier. It should indeed work properly in all cases (if `intl` is available). About the polyfill: we could also change...
@izelnakri would you be so kind and add a failing test / show an example that fails?
@mcpiroman would you be so kind and rebase and force push instead of merging? Our CI does not work otherwise. You can do that along of these commands: ``` git...