BrianLMatthews

Results 9 comments of BrianLMatthews

No, it’s actually on purpose (at least going by it being tested for 😆). According to the test (starting on `spec/unit/attributes/update_spec.rb:308`) it’s for the case of changing a `has_and_belongs_to_many` field...

Just dropping the `unless v.all?(&:blank?)` would make one spec fail, the one I pointed out in my previous message. I tend to be conservative in making changes so I’d add...

I’m not sure why you would want to track just some changes. In my case I definitely want the first two tracked, and maybe the 3rd, although I’d have to...

Which kind of makes my point. It’s noise to you, it’s definitely not to me. mongoid-history has no way to know our different needs so shouldn’t be making those kinds...

Before I do a PR I’d like to at least agree on a general approach. My suggestion (and what I’d do in a PR) would be: 1. Add a `track_all_blank`...

> I think should separate “False” from “Blank” in this context. I see that as a separate issue. I, personally, don’t think mongoid-history should be doing any implicit filtering of...

https://github.com/mongoid/mongoid-history/pull/257

Just decided to generate the title tag myself. The way I’m using it that’s an easy change in one place, so sufficient for me. Feel free to close this issue.