Brian Hung
Brian Hung
Great fix for developers trying to chain multiple commands together but only have one undo / redo for all using the `appendedTransaction` meta.
I believe sampling only 10 rows as opposed to _all rows_ was an intentional performance optimization, as summing heights for thousands or millions of rows is an issue.
Workaround for now is to override `drawHeader`. Issue with header right now is that it has all these icons that if right aligned, is undefined behavior.
Yeah, it is a breaking change. Maybe we can pass in (cell: GridCell & Item), then it wouldn't be a breaking change with a required second arg. What do you...
Does getting rid of the carriage return work? If so, we can just normalize the data `.replace(/\r\n?/g, "\n")`. Saw something similar with https://github.com/ProseMirror/prosemirror/issues/1138 We could also maybe just strip _trailing_...
Tried reproducing with the desktop Excel app on MacOS; might be an OS thing but the `onPasteInternal` logic reads from `navigator.clipboard` instead of `e.clipboardData`.
If you're able to reproduce this consistently in a test case, that would help: I don't have Excel installed 😓 Alternatively, paste what's in the clipboard: the expected output, and...
Good catch! PR up.
Feel free to jump into this discord thread: https://discord.com/channels/1200006940210757672/1287965416689238047/1288223592936374323 The main blocker is how should we handle conflicting ids.
If your command mutates the doc, it has to be the last 'command'. You also cannot have consecutive commands that mutate the doc. That's what the applying mismatched transaction means....