feat: provideEditorCallback access cell location

Open BrianHung opened this issue 7 months ago • 1 comments

Most of api is

(cell: Item, value: GridCell) but that would be a breaking change here.

Jun 05 '25 20:06 BrianHung

Yeah, it is a breaking change. Maybe we can pass in (cell: GridCell & Item), then it wouldn't be a breaking change with a required second arg. What do you think?

Jun 18 '25 16:06 BrianHung

LGTM 👍 I think the main downside with the updated impl. is that it would overwrite a location prop of a built-in cell. But none of the built-in cells use this property yet -> should be good to go

One small related nice-to-have addition might be a storybook case for provideEditor. I don't think we have one at the moment. But we can also do that in another PR, whatever you prefer.

Jun 25 '25 16:06 lukasmasuch