Brian Hawley

Results 55 comments of Brian Hawley

#725 fixes the same bug but does the change I suggested instead. It should be used instead.

#725 fixes the same bug but does the change I suggested instead. It should be used instead.

Looking at the Ruby logger source, it also passes a nil message from the `info` method to the `add` method, with source pretty much identical to the source in ForwardingLogger....

@ngoral I fixed ForwardingLogger's `add` method to forward the block parameter. You should fix your custom logger's `add` method to use the same parameter handling tricks as Ruby's Logger class:...

Yeah, I already reported this in #5365. The workaround you mentioned in your comment above is how I worked around it.

For this kind of issue, you need to say which hardware platform and ruby version you are using. https://rubygems.org/gems/pyroscope shows gems with precompiled binaries for x86_64-linux and aarch64-linux. Ubuntu 22.04...

JRuby works for me, both 1.7.x and 9k. What is your host platform? Which JRuby version are you using? What code did you use to generate this error? Which version...

Looks like you're attempting to use a version of uglifier that doesn't support ES6 syntax; string interpolation isn't ES5 compatible. Did you try updating uglifier to a newer version, 3.2.0+...

@fede-moya could you merge this one? It's just `bundle update` and `rake docs:scrape`.

@fede-moya could you merge this one? It includes fixes for Rails 7.1 projects, so it's a critical upgrade.