Brian Hawley

Results 55 comments of Brian Hawley

@fede-moya or @filipesperandio could you review and merge? This should also be able to be cherry-picked to other new channels, though they really should be based on channel/beta anyways so...

@fede-moya this change is still needed. Could you review?

Hotpatch initializer to fix this issue: ```ruby # frozen_string_literal: true begin DatabaseValidations::Adapters.factory(ActiveRecord::Base) rescue DatabaseValidations::Errors::UnknownDatabase # Add support for the postgis adapter. DatabaseValidations::Adapters::PostgresqlAdapter.send(:remove_const, :ADAPTER) DatabaseValidations::Adapters::PostgresqlAdapter::ADAPTER = /\A(?:postgresql|postgis)\z/ end ``` This is...

I also ran it with `RUST_BACKTRACE=1` as suggested: ``` thread '' panicked at 'called `Result::unwrap()` on an `Err` value: SetLoggerError(())', /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pretty_env_logger-0.4.0/src/lib.rs:74:22 stack backtrace: 0: _rust_begin_unwind 1: core::panicking::panic_fmt 2: core::result::unwrap_failed 3:...

With `RUST_BACKTRACE=full` I get this: ``` thread '' panicked at 'called `Result::unwrap()` on an `Err` value: SetLoggerError(())', /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pretty_env_logger-0.4.0/src/lib.rs:74:22 stack backtrace: 0: 0x10d4621ba - ::fmt::hae51cb91d407e2ef 1: 0x10d219f6b - core::fmt::write::h746bc0969202388b 2: 0x10d43feec...

Looks like the code is calling: ```rust pretty_env_logger::init_timed(); ``` I checked the source of that, and internally it's calling the `try_init_timed()` function, which returns a `Result`, then it's just calling...

I checked the new version that came out on April 15, and it still has the same issue.

Technically, the thread-safe Rails transactional cleanup has been there since Rails 5.1, but there was a bug in the mysql connection adapter code that wasn't thread-safe, which was fixed in...

I think I've figured out how to write the tests with the existing matrix, and a slight tweak of the existing test setup code, just adding a couple tests to...

See also https://github.com/wkhtmltopdf/packaging/issues/98