Boxy comments

Results 83 comments of


                                            Boxy

Document inferred const args (`feature(generic_arg_infer)`)

@traviscross @ehuss friendly poke about this :)

Document inferred const args (`feature(generic_arg_infer)`)

> I'm a little lost, as it seems like there are two distinct things being supported here There is one thing being added, we support `_` (optionally wrapped in arbitrary...

Document inferred const args (`feature(generic_arg_infer)`)

Sorry I feel like I'm repeating myself a bit here and am not sure how to explain this better. This feature is orthogonal to underscores as an expression. It's not...

Note the version and PR of removed features when using it

@bors r+ I didn't really check that all the PR numbers associated with removed features are correct because that seems so incredibly mind numbingly tedious, and the cost of getting...

Note the version and PR of removed features when using it

Thank you for doing that work :3

Detect struct construction with private field in field with default

@bors r+ rollup=iffy not sure if there will be perf impact from the pathsource stuff

rustdoc query cycle regression

I'm not sure how #139635 would have caused this, it doesn't touch anything to do with what queries get called so shouldn't be introducing new query cycles. @tamird what makes...

rustdoc query cycle regression

Ah I see what you mean. I'll take a look and see what happened there and verify if it was that PR that caused it.

rustdoc query cycle regression

@tamird I can't seem to reproduce the failure locally, though I did notice that the crate *sometimes* uses `generic_const_exprs`. Is the CI failure happening in a place where the `unstable`...

rustdoc query cycle regression

Ah running `cargo xtask public-api --bless` reproduces it and stops when removing the enabling of `generic_const_exprs`. So I think this is a gce only regression, and also seems reasonable to...