rust icon indicating copy to clipboard operation
rust copied to clipboard

Note the version and PR of removed features when using it

Open xizheyin opened this issue 7 months ago • 14 comments

Fixes rust-lang/rust#141619

I added the diagnostic information. Since all the current version information is present, it prints the version information anyway, as shown in tests/ui. And PR will not print if it is None, we can gradually add the PR links.

Split into two commits for easier review.

r? compiler

cc @jyn514 Since you're on vocation in the review list, I can't r? you.

xizheyin avatar May 27 '25 09:05 xizheyin

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#18 exporting to docker image format
#18 sending tarball 20.5s done
#18 DONE 27.4s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---

4 LL | #![feature(no_stack_check)]
5    |            ^^^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.0.0 (you are using 1.89.0-dev)
+    = note: removed in 1.0.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
8 
9 error: aborting due to 1 previous error
10 


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args deprecation/deprecated_no_stack_check.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/deprecation/deprecated_no_stack_check.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/deprecation/deprecated_no_stack_check" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/deprecation/deprecated_no_stack_check.rs:2:12
   |
LL | #![feature(no_stack_check)]
   |            ^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(no_coverage)]
5    |            ^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.74.0 (you are using 1.89.0-dev)
+    = note: removed in 1.74.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
8    = note: renamed to `coverage_attribute`
9 
10 error[E0658]: the `#[coverage]` attribute is an experimental feature


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/feature-gate-coverage-attribute.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-coverage-attribute" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs:2:12
   |
LL | #![feature(no_coverage)] //~ ERROR feature has been removed [E0557]
   |            ^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.74.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
   = note: renamed to `coverage_attribute`

error[E0658]: the `#[coverage]` attribute is an experimental feature
##[error]  --> /checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs:10:1
   |
LL | #[coverage(off)] //~ ERROR the `#[coverage]` attribute is an experimental feature
   | ^^^^^^^^^^^^^^^^
   |
   = note: see issue #84605 <https://github.com/rust-lang/rust/issues/84605> for more information
   = help: add `#![feature(coverage_attribute)]` to the crate attributes to enable
   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0557, E0658.
For more information about an error, try `rustc --explain E0557`.
---

16 LL | #![feature(test_removed_feature)]
17    |            ^^^^^^^^^^^^^^^^^^^^ feature has been removed
18    |
-    = note: removed in 1.0.0 (you are using 1.89.0-dev)
+    = note: removed in 1.0.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
20 
21 error: malformed `feature` attribute input
22   --> $DIR/gated-bad-feature.rs:6:1


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/gated-bad-feature.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/gated-bad-feature.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/gated-bad-feature" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0556]: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:1:25
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |                         ^^^^^^^^ help: expected just one word: `foo`

error[E0556]: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:1:35
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |                                   ^^^^^^^^^^^ help: expected just one word: `foo`

error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:8:12
   |
LL | #![feature(test_removed_feature)] //~ ERROR: feature has been removed
   |            ^^^^^^^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))

error: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:6:1
   |
LL | #![feature] //~ ERROR malformed `feature` attribute
   | ^^^^^^^^^^^ help: must be of the form: `#![feature(name1, name2, ...)]`

error: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:7:1
   |
LL | #![feature = "foo"] //~ ERROR malformed `feature` attribute
   | ^^^^^^^^^^^^^^^^^^^ help: must be of the form: `#![feature(name1, name2, ...)]`

error[E0635]: unknown feature `foo_bar_baz`
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:1:12
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |            ^^^^^^^^^^^

error[E0635]: unknown feature `foo`
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:1:48
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |                                                ^^^

error: aborting due to 7 previous errors

Some errors have detailed explanations: E0556, E0557, E0635.
---

4 LL | #![feature(external_doc)]
5    |            ^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.54.0 (you are using 1.89.0-dev); see <https://github.com/rust-lang/rust/pull/85457> for more information
+    = note: removed in 1.54.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27)); see <https://github.com/rust-lang/rust/pull/85457> for more information
8    = note: use #[doc = include_str!("filename")] instead, which handles macro invocations
9 
10 error: unknown `doc` attribute `include`


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/removed-features-note-version-and-pr-issue-141619.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/removed-features-note-version-and-pr-issue-141619.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/removed-features-note-version-and-pr-issue-141619" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/removed-features-note-version-and-pr-issue-141619.rs:1:12
   |
LL | #![feature(external_doc)] //~ ERROR feature has been removed
   |            ^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.54.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27)); see <https://github.com/rust-lang/rust/pull/85457> for more information
   = note: use #[doc = include_str!("filename")] instead, which handles macro invocations

error: unknown `doc` attribute `include`
##[error]  --> /checkout/tests/ui/feature-gates/removed-features-note-version-and-pr-issue-141619.rs:2:8
   |
LL | #![doc(include("README.md"))] //~ ERROR unknown `doc` attribute `include`
   |        ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[deny(invalid_doc_attributes)]` on by default

error: aborting due to 2 previous errors
---

4 LL | #![feature(macro_reexport)]
5    |            ^^^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.0.0 (you are using 1.89.0-dev)
+    = note: removed in 1.0.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
8    = note: subsumed by `pub use`
9 
10 error: cannot find attribute `macro_reexport` in this scope


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args macros/macro-reexport-removed.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/macros/macro-reexport-removed.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/macros/macro-reexport-removed" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/macros/macro-reexport-removed/auxiliary"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/macros/macro-reexport-removed.rs:3:12
   |
LL | #![feature(macro_reexport)] //~ ERROR feature has been removed
   |            ^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
   = note: subsumed by `pub use`

error: cannot find attribute `macro_reexport` in this scope
##[error]  --> /checkout/tests/ui/macros/macro-reexport-removed.rs:5:3
   |
LL | #[macro_reexport(macro_one)] //~ ERROR cannot find attribute `macro_reexport` in this scope
   |   ^^^^^^^^^^^^^^ help: a built-in attribute with a similar name exists: `macro_export`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(doc_keyword)]
5    |            ^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.28.0 (you are using 1.89.0-dev)
+    = note: removed in 1.28.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
8    = note: merged into `#![feature(rustdoc_internals)]`
9 
10 error[E0557]: feature has been removed

13 LL | #![feature(doc_primitive)]
14    |            ^^^^^^^^^^^^^ feature has been removed
15    |
-    = note: removed in 1.56.0 (you are using 1.89.0-dev)
+    = note: removed in 1.56.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
17    = note: merged into `#![feature(rustdoc_internals)]`
18 
19 error: aborting due to 2 previous errors


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args rustdoc/renamed-features-rustdoc_internals.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rustdoc/renamed-features-rustdoc_internals" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs:1:12
   |
LL | #![feature(doc_keyword)] //~ ERROR
   |            ^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.28.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
   = note: merged into `#![feature(rustdoc_internals)]`

error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs:2:12
   |
LL | #![feature(doc_primitive)] //~ ERROR
   |            ^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.56.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
   = note: merged into `#![feature(rustdoc_internals)]`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(const_trait_impl, effects)]
5    |                              ^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.84.0 (you are using 1.89.0-dev)
+    = note: removed in 1.84.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
8    = note: removed, redundant with `#![feature(const_trait_impl)]`
9 
10 error[E0049]: associated function `compute` has 0 type parameters but its trait declaration has 1 type parameter


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args traits/const-traits/const-trait-impl-parameter-mismatch.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/const-traits/const-trait-impl-parameter-mismatch" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs:10:30
   |
LL | #![feature(const_trait_impl, effects)]
   |                              ^^^^^^^ feature has been removed
   |
   = note: removed in 1.84.0 (you are using 1.89.0-nightly (896b7c329 2025-05-27))
   = note: removed, redundant with `#![feature(const_trait_impl)]`

error[E0049]: associated function `compute` has 0 type parameters but its trait declaration has 1 type parameter
##[error]  --> /checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs:19:16
   |
LL |     fn compute<T: ~const Aux>() -> u32;
   |                - expected 1 type parameter
...
LL |     fn compute<'x>() -> u32 {
   |                ^^ found 0 type parameters

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0049, E0557.
For more information about an error, try `rustc --explain E0049`.

rust-log-analyzer avatar May 27 '25 09:05 rust-log-analyzer

r? compiler (bandwidth)

jieyouxu avatar May 27 '25 11:05 jieyouxu

I tried opt_nonzero_u32!($($pull)?),, but it reports

error[E0015]: cannot call non-const method `std::option::Option::<NonZero<u32>>::or` in statics

So, I use helper macros to parse pull.

xizheyin avatar May 27 '25 14:05 xizheyin

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#18 exporting to docker image format
#18 sending tarball 20.3s done
#18 DONE 29.1s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---

4 LL | #![feature(no_stack_check)]
5    |            ^^^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.0.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
8 
9 error: aborting due to 1 previous error
10 

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.0.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args deprecation/deprecated_no_stack_check.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/deprecation/deprecated_no_stack_check.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/deprecation/deprecated_no_stack_check" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/deprecation/deprecated_no_stack_check.rs:4:12
   |
---

4 LL | #![feature(no_coverage)]
5    |            ^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.74.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.74.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
8    = note: renamed to `coverage_attribute`
9 
10 error[E0658]: the `#[coverage]` attribute is an experimental feature

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.74.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
+    = note: removed in 1.74.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/feature-gate-coverage-attribute.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-coverage-attribute" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs:4:12
   |
LL | #![feature(no_coverage)] //~ ERROR feature has been removed [E0557]
   |            ^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.74.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
   = note: renamed to `coverage_attribute`

error[E0658]: the `#[coverage]` attribute is an experimental feature
##[error]  --> /checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs:12:1
   |
LL | #[coverage(off)] //~ ERROR the `#[coverage]` attribute is an experimental feature
   | ^^^^^^^^^^^^^^^^
   |
   = note: see issue #84605 <https://github.com/rust-lang/rust/issues/84605> for more information
   = help: add `#![feature(coverage_attribute)]` to the crate attributes to enable
   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0557, E0658.
For more information about an error, try `rustc --explain E0557`.
---

16 LL | #![feature(test_removed_feature)]
17    |            ^^^^^^^^^^^^^^^^^^^^ feature has been removed
18    |
-    = note: removed in 1.0.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
20 
21 error: malformed `feature` attribute input
22   --> $DIR/gated-bad-feature.rs:7:1

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.0.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/gated-bad-feature.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/gated-bad-feature.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/gated-bad-feature" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0556]: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:2:25
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |                         ^^^^^^^^ help: expected just one word: `foo`

error[E0556]: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:2:35
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |                                   ^^^^^^^^^^^ help: expected just one word: `foo`

error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:9:12
   |
LL | #![feature(test_removed_feature)] //~ ERROR: feature has been removed
   |            ^^^^^^^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (473126862 2025-05-27))

error: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:7:1
   |
LL | #![feature] //~ ERROR malformed `feature` attribute
   | ^^^^^^^^^^^ help: must be of the form: `#![feature(name1, name2, ...)]`

error: malformed `feature` attribute input
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:8:1
   |
LL | #![feature = "foo"] //~ ERROR malformed `feature` attribute
   | ^^^^^^^^^^^^^^^^^^^ help: must be of the form: `#![feature(name1, name2, ...)]`

error[E0635]: unknown feature `foo_bar_baz`
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:2:12
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |            ^^^^^^^^^^^

error[E0635]: unknown feature `foo`
##[error]  --> /checkout/tests/ui/feature-gates/gated-bad-feature.rs:2:48
   |
LL | #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]
   |                                                ^^^

error: aborting due to 7 previous errors

Some errors have detailed explanations: E0556, E0557, E0635.
---

4 LL | #![feature(external_doc)]
5    |            ^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.54.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/85457> for more information
+    = note: removed in 1.54.0 (you are using $RUSTC_VERSION (473126862 2025-05-27)); see <https://github.com/rust-lang/rust/pull/85457> for more information
8    = note: use #[doc = include_str!("filename")] instead, which handles macro invocations
9 
10 error: unknown `doc` attribute `include`

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.54.0 (you are using 1.89.0-nightly (473126862 2025-05-27)); see <https://github.com/rust-lang/rust/pull/85457> for more information
+    = note: removed in 1.54.0 (you are using $RUSTC_VERSION (473126862 2025-05-27)); see <https://github.com/rust-lang/rust/pull/85457> for more information


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/removed-features-note-version-and-pr-issue-141619.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/removed-features-note-version-and-pr-issue-141619.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/removed-features-note-version-and-pr-issue-141619" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/removed-features-note-version-and-pr-issue-141619.rs:3:12
   |
LL | #![feature(external_doc)] //~ ERROR feature has been removed
   |            ^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.54.0 (you are using 1.89.0-nightly (473126862 2025-05-27)); see <https://github.com/rust-lang/rust/pull/85457> for more information
   = note: use #[doc = include_str!("filename")] instead, which handles macro invocations

error: unknown `doc` attribute `include`
##[error]  --> /checkout/tests/ui/feature-gates/removed-features-note-version-and-pr-issue-141619.rs:4:8
   |
LL | #![doc(include("README.md"))] //~ ERROR unknown `doc` attribute `include`
   |        ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[deny(invalid_doc_attributes)]` on by default

error: aborting due to 2 previous errors
---

4 LL | #![feature(macro_reexport)]
5    |            ^^^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.0.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
8    = note: subsumed by `pub use`
9 
10 error: cannot find attribute `macro_reexport` in this scope

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.0.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args macros/macro-reexport-removed.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/macros/macro-reexport-removed.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/macros/macro-reexport-removed" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/macros/macro-reexport-removed/auxiliary"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/macros/macro-reexport-removed.rs:4:12
   |
LL | #![feature(macro_reexport)] //~ ERROR feature has been removed
   |            ^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
   = note: subsumed by `pub use`

error: cannot find attribute `macro_reexport` in this scope
##[error]  --> /checkout/tests/ui/macros/macro-reexport-removed.rs:6:3
   |
LL | #[macro_reexport(macro_one)] //~ ERROR cannot find attribute `macro_reexport` in this scope
   |   ^^^^^^^^^^^^^^ help: a built-in attribute with a similar name exists: `macro_export`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(doc_keyword)]
5    |            ^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.28.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.28.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
8    = note: merged into `#![feature(rustdoc_internals)]`
9 
10 error[E0557]: feature has been removed

13 LL | #![feature(doc_primitive)]
14    |            ^^^^^^^^^^^^^ feature has been removed
15    |
-    = note: removed in 1.56.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.56.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
17    = note: merged into `#![feature(rustdoc_internals)]`
18 
19 error: aborting due to 2 previous errors

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.28.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
-    = note: removed in 1.56.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
+    = note: removed in 1.28.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
+    = note: removed in 1.56.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args rustdoc/renamed-features-rustdoc_internals.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rustdoc/renamed-features-rustdoc_internals" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs:3:12
   |
LL | #![feature(doc_keyword)] //~ ERROR
   |            ^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.28.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
   = note: merged into `#![feature(rustdoc_internals)]`

error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs:4:12
   |
LL | #![feature(doc_primitive)] //~ ERROR
   |            ^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.56.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
   = note: merged into `#![feature(rustdoc_internals)]`

---

4 LL | #![feature(const_trait_impl, effects)]
5    |                              ^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.84.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.84.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))
8    = note: removed, redundant with `#![feature(const_trait_impl)]`
9 
10 error[E0049]: associated function `compute` has 0 type parameters but its trait declaration has 1 type parameter

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.84.0 (you are using 1.89.0-nightly (473126862 2025-05-27))
+    = note: removed in 1.84.0 (you are using $RUSTC_VERSION (473126862 2025-05-27))


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args traits/const-traits/const-trait-impl-parameter-mismatch.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/const-traits/const-trait-impl-parameter-mismatch" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs:11:30
   |
---

error[E0049]: associated function `compute` has 0 type parameters but its trait declaration has 1 type parameter
##[error]  --> /checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs:20:16
   |
LL |     fn compute<T: ~const Aux>() -> u32;
   |                - expected 1 type parameter
...
LL |     fn compute<'x>() -> u32 {
   |                ^^ found 0 type parameters

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0049, E0557.
For more information about an error, try `rustc --explain E0049`.

rust-log-analyzer avatar May 27 '25 14:05 rust-log-analyzer

gotcha - can you write out the match explicitly instead of using or? i do think for this file specifically that having an accurate git blame is helpful.

separately i will open an issue to make or const, there's no reason for it not to be.

jyn514 avatar May 27 '25 14:05 jyn514

I push the third commits to make since of removed features the version in which it was removed and fill pull.

I find the corresponding PR by going through all the features in removed.rs one by one and checking their corresponding git blame. if I don't have a query because it's too old, I search for keywords in PR in rust-lang/rust. The vast majority of them found the corresponding PRs, so please reviewers review them when you have time.

If there's nothing wrong with this PR, #141619 will be closed when it is merged.

xizheyin avatar Jun 04 '25 09:06 xizheyin

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

4 LL | #![feature(no_stack_check)]
5    |            ^^^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.0.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/40110> for more information
8 
9 error: aborting due to 1 previous error
10 

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.0.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/40110> for more information
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/40110> for more information


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args deprecation/deprecated_no_stack_check.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/deprecation/deprecated_no_stack_check.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/deprecation/deprecated_no_stack_check" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/deprecation/deprecated_no_stack_check.rs:4:12
   |
LL | #![feature(no_stack_check)]
   |            ^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/40110> for more information

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(no_coverage)]
5    |            ^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.74.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.74.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/114656> for more information
8    = note: renamed to `coverage_attribute`
9 
10 error[E0658]: the `#[coverage]` attribute is an experimental feature

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.74.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/114656> for more information
+    = note: removed in 1.74.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/114656> for more information


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/feature-gate-coverage-attribute.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-coverage-attribute" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs:4:12
   |
LL | #![feature(no_coverage)] //~ ERROR feature has been removed [E0557]
   |            ^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.74.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/114656> for more information
   = note: renamed to `coverage_attribute`

error[E0658]: the `#[coverage]` attribute is an experimental feature
##[error]  --> /checkout/tests/ui/feature-gates/feature-gate-coverage-attribute.rs:12:1
   |
LL | #[coverage(off)] //~ ERROR the `#[coverage]` attribute is an experimental feature
   | ^^^^^^^^^^^^^^^^
   |
   = note: see issue #84605 <https://github.com/rust-lang/rust/issues/84605> for more information
   = help: add `#![feature(coverage_attribute)]` to the crate attributes to enable
   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0557, E0658.
For more information about an error, try `rustc --explain E0557`.
---

4 LL | #![feature(macro_reexport)]
5    |            ^^^^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.0.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/49982> for more information
8    = note: subsumed by `pub use`
9 
10 error: cannot find attribute `macro_reexport` in this scope

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.0.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/49982> for more information
+    = note: removed in 1.0.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/49982> for more information


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args macros/macro-reexport-removed.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/macros/macro-reexport-removed.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/macros/macro-reexport-removed" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/macros/macro-reexport-removed/auxiliary"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/macros/macro-reexport-removed.rs:4:12
   |
LL | #![feature(macro_reexport)] //~ ERROR feature has been removed
   |            ^^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.0.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/49982> for more information
   = note: subsumed by `pub use`

error: cannot find attribute `macro_reexport` in this scope
##[error]  --> /checkout/tests/ui/macros/macro-reexport-removed.rs:6:3
   |
LL | #[macro_reexport(macro_one)] //~ ERROR cannot find attribute `macro_reexport` in this scope
   |   ^^^^^^^^^^^^^^ help: a built-in attribute with a similar name exists: `macro_export`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(doc_keyword)]
5    |            ^^^^^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.28.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.58.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/90420> for more information
8    = note: merged into `#![feature(rustdoc_internals)]`
9 
10 error[E0557]: feature has been removed

13 LL | #![feature(doc_primitive)]
14    |            ^^^^^^^^^^^^^ feature has been removed
15    |
-    = note: removed in 1.56.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.58.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/90420> for more information
17    = note: merged into `#![feature(rustdoc_internals)]`
18 
19 error: aborting due to 2 previous errors

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.58.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/90420> for more information
-    = note: removed in 1.58.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/90420> for more information
+    = note: removed in 1.58.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/90420> for more information
+    = note: removed in 1.58.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/90420> for more information


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args rustdoc/renamed-features-rustdoc_internals.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rustdoc/renamed-features-rustdoc_internals" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs:3:12
   |
LL | #![feature(doc_keyword)] //~ ERROR
   |            ^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.58.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/90420> for more information
   = note: merged into `#![feature(rustdoc_internals)]`

error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/rustdoc/renamed-features-rustdoc_internals.rs:4:12
   |
LL | #![feature(doc_primitive)] //~ ERROR
   |            ^^^^^^^^^^^^^ feature has been removed
   |
   = note: removed in 1.58.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/90420> for more information
   = note: merged into `#![feature(rustdoc_internals)]`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0557`.
------------------------------------------
---

4 LL | #![feature(const_trait_impl, effects)]
5    |                              ^^^^^^^ feature has been removed
6    |
-    = note: removed in 1.84.0 (you are using $RUSTC_VERSION)
+    = note: removed in 1.84.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/132479> for more information
8    = note: removed, redundant with `#![feature(const_trait_impl)]`
9 
10 error[E0049]: associated function `compute` has 0 type parameters but its trait declaration has 1 type parameter

Note: some mismatched output was normalized before being compared
-    = note: removed in 1.84.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/132479> for more information
+    = note: removed in 1.84.0 (you are using $RUSTC_VERSION); see <https://github.com/rust-lang/rust/pull/132479> for more information


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args traits/const-traits/const-trait-impl-parameter-mismatch.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/const-trait-impl-parameter-mismatch" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver"
stdout: none
--- stderr -------------------------------
error[E0557]: feature has been removed
##[error]  --> /checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs:11:30
   |
LL | #![feature(const_trait_impl, effects)]
   |                              ^^^^^^^ feature has been removed
   |
   = note: removed in 1.84.0 (you are using 1.89.0-nightly (501946494 2025-06-04)); see <https://github.com/rust-lang/rust/pull/132479> for more information
   = note: removed, redundant with `#![feature(const_trait_impl)]`

error[E0049]: associated function `compute` has 0 type parameters but its trait declaration has 1 type parameter
##[error]  --> /checkout/tests/ui/traits/const-traits/const-trait-impl-parameter-mismatch.rs:20:16
   |
LL |     fn compute<T: ~const Aux>() -> u32;
   |                - expected 1 type parameter
...
LL |     fn compute<'x>() -> u32 {
   |                ^^ found 0 type parameters

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0049, E0557.
For more information about an error, try `rustc --explain E0049`.

rust-log-analyzer avatar Jun 04 '25 09:06 rust-log-analyzer

r? compiler

xizheyin avatar Jun 07 '25 06:06 xizheyin

wesleywiser may not have time as he put off another PR review yesterday. r? compiler

xizheyin avatar Jun 07 '25 06:06 xizheyin

:umbrella: The latest upstream changes (presumably #142220) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jun 09 '25 06:06 bors

@bors r+

I didn't really check that all the PR numbers associated with removed features are correct because that seems so incredibly mind numbingly tedious, and the cost of getting this wrong is extremely small.

BoxyUwU avatar Jun 10 '25 04:06 BoxyUwU

:pushpin: Commit 4b898041f63c488e7173a5e161955aa3cafceb2f has been approved by BoxyUwU

It is now in the queue for this repository.

bors avatar Jun 10 '25 04:06 bors

Yes, it took me hours to go through all the features. It's really boring. :)

xizheyin avatar Jun 10 '25 06:06 xizheyin

Thank you for doing that work :3

BoxyUwU avatar Jun 10 '25 07:06 BoxyUwU