David Heidrich

Results 22 comments of David Heidrich

+1 for this, in the meantime just do: ``` javascript $(window).unbind("scroll"); ``` and recreate the widget

Thank you for having a look :). Rewriting the library / Adding types for it is out of my scope currently timewise, but I can provide types for it, as...

I also tried to use the current version directly from google (`@google/markerwithlabel`), but it seems there is a bug on the latest version (see https://github.com/googlemaps/v3-utility-library/issues/651). I ran into the same...

I can't test the implementation currently as it seems like there are several issues: ``` VM762:11 Uncaught SyntaxError: Identifier 'InfoBox' has already been declared at new Function () ``` ...and...

I have a general question, why not using the new @google packages for the implementations (e.g. @google/markerclustererplus etc.) instead of porting /copying the dependencies. It seems redundant to me and...

@GGAlanSmithee, At least network-first (see function `networkFirstResponse`) will always load from cache when != ok. @NekR maybe something like: `shouldServeFromCache: (response:Object, cacheUrl:string, url:string) => boolean` defaults to `(response) => !response.ok`...

Real world usecase: Imagine having the following configuration: ```javascript const config = { /*...*/ externals: ['/de-de', '/en-en'], cacheMaps: [{ match: function match(requestUrl) { const localeMatch = requestUrl.pathname.match(/(\/[a-z]{2}-[a-z]{2})(.*)/); if (localeMatch &&...

@NekR is there more information necessary?

@NekR we fixed the failing tests due to updates in the meantime. Is there anything else we can provide?