Borys

> Probably related: #2907 it's a different problem

`void Scheduler::ScheduleFromRemote(FiberInterface* cntx) { // This function is called from FiberInterface::ActivateOther from a remote scheduler. // But the fiber belongs to this scheduler. DCHECK(cntx->scheduler_ == this); // If someone else...

` optional multi_mode = DeduceExecMode(state, exec_info, *script_mgr()); if (!multi_mode) return rb->SendError( "Dragonfly does not allow execution of a server-side Lua in Multi transaction"); ` condition is always false

` if (conn_state.subscribe_info) { // Clean-ups related to PUBSUB if (!conn_state.subscribe_info->channels.empty()) { server_cntx->UnsubscribeAll(false); } if (conn_state.subscribe_info) { // always true DCHECK(!conn_state.subscribe_info->patterns.empty()); server_cntx->PUnsubscribeAll(false); } DCHECK(!conn_state.subscribe_info); }`

OpStatus OpSetId2(const OpArgs& op_args, string_view key, const streamID& sid) { .... long long entries_added = -1; .... if (entries_added != -1)

size_t node_max_bytes = kStreamNodeMaxBytes; if (node_max_bytes == 0 || node_max_bytes > STREAM_LISTPACK_MAX_SIZE) node_max_bytes = STREAM_LISTPACK_MAX_SIZE;

unsigned int ziplistRandomPairsUnique(unsigned char *zl, unsigned int count, ziplistEntry *keys, ziplistEntry *vals) { unsigned char *p, *key; .... assert(ziplistGet(p, &key, &klen, &klval)); ziplistSaveValue(key, klen, klval, &keys[picked]);

assert(ziplistGet(p, &value, &vlen, &vlval)); while (pickindex < count && zipindex == picks[pickindex].index) { int storeorder = picks[pickindex].order; ziplistSaveValue(key, klen, klval, &keys[storeorder]); if (vals) ziplistSaveValue(value, vlen, vlval, &vals[storeorder]); pickindex++; It looks...

DCHECK(it == blocks_.begin() || it == blocks_.begin() || it->Size() * 2 >= block_size_); duplication check, maybe a bug

I think it's a false positive, I haven't dived deep when I analyzed the static analysis results. You can hide the comment and I will know that I was wrong...