BlockListed
BlockListed
> first question would be, why change `Host` to `Domain`? That is not how the header is called. > > And a dev tip, install and activate `pre-commit`, that will...
> > Because it definitely isn't a host. > > https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host It does not store a host. It stores a base url. If it stored a host the extractor would...
> Ot definitely isn't a domain, a domain is the last 2 (or 3) parts. So, a domain is `vaultwarden.org`, a host is `vault.vaultwarden.org`, so what we are receiving is...
> > > Ot definitely isn't a domain, a domain is the last 2 (or 3) parts. So, a domain is `vaultwarden.org`, a host is `vault.vaultwarden.org`, so what we are...
> There are some issues. Mails can be sent without any HTTP connection, so there must be one main host/domain in the config which will be used in those cases....
Checks are passing now, but I still have some cleanup to be done. Probably will do it tomorrow, after that it should be ready for review. ## To do (at...
From my perspective I would say this is ready to review.
@BlackDex Sorry for the ping, but is anything gonna happen with this PR? Because if not, it should probably just be closed.