Prince Canuma
Prince Canuma
Please rebase this branch and match @prncvrm's PR (now on main), I made some small changes and fixes. After that we can merge :)
Merged all the fixes here #378
@lucasnewman that notebook seems to be broken according to their repo. Give it a try but if it doesn't work we'll need to wait till they fix it.
I requested them to fix it on X a couple of weeks ago when they were gathering feedback from the launch.
Sure, will do ASAP. Just finishing uploading ModernBert
Sure, let me know when it's ready to review or if you need my help :)
> Ok, I ran the implementation above in a Colab with CUDA, and it has the exact same tokenization scheme (good) and gets the same weird results that no reasonable...
@dwohlfahrt could you try the same prompts with the closed PR from @lucasnewman and see if the results match the torch. If so, I think we can re-open it and...
Could you add a warning ⚠️ for users to let them know about potential issues ?