mlx-vlm icon indicating copy to clipboard operation
mlx-vlm copied to clipboard
Published 2 months ago • verified publisher icon Blaizzy

Apply PR #319 fixes to Qwen 2.5VL position id

Open ddupont808 opened this issue 9 months ago • 4 comments

Ports PR #319 changes to Qwen 2.5VL implementation

ddupont808 avatar May 10 '25 20:05 ddupont808

Thank you very much @ddupont808!

Small nit: As suggested in @prncvrm's PR please move the position ID calculations inside the language.py it can be exactly in the LanguageModel() otherwise it won't work well for multi-turn.

Blaizzy avatar May 10 '25 20:05 Blaizzy

Thank you @ddupont808 , i'll be raising the fix by tomorrow, was away for a couple of days

prncvrm avatar May 13 '25 13:05 prncvrm

@ddupont808 i've raised the fix, please pull and update

prncvrm avatar May 14 '25 12:05 prncvrm

Please rebase this branch and match @prncvrm's PR (now on main), I made some small changes and fixes.

After that we can merge :)

Blaizzy avatar May 14 '25 22:05 Blaizzy

Merged all the fixes here #378

Blaizzy avatar Jun 04 '25 14:06 Blaizzy