Blackbit

Results 38 comments of Blackbit

Now also affects tree loading performance, this also contained a similarly slow query part in https://github.com/pimcore/pimcore/blob/b675696e8c3dff29e51d97e67fc79d3003c9ca3a/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectController.php#L215-L227 For above client instead of 3 seconds, now 0.8s for loading `/admin/object/tree-get-childs-by-id`. Now you...

@kingjia90 Thanks. Will edit the PR...

As soon as the tests are green, I can do another performance comparison. Obviously my initial assumption that as soon as `list` is allowed for `/a` then it will also...

@kingjia90 Imho the test is wrong. The tests which currently fails is https://github.com/pimcore/pimcore/blob/bc483848fba6f3c937676361d634ecedb9d0247c/tests/Model/Permissions/ModelDataObjectPermissionsTest.php#L705-L709 `$this->permissionfoo` is defined in https://github.com/pimcore/pimcore/blob/bc483848fba6f3c937676361d634ecedb9d0247c/tests/Model/Permissions/ModelDataObjectPermissionsTest.php#L159 So we have a folder `/permissionfoo` It has one child element: https://github.com/pimcore/pimcore/blob/bc483848fba6f3c937676361d634ecedb9d0247c/tests/Model/Permissions/ModelDataObjectPermissionsTest.php#L162...

Next failing test is https://github.com/pimcore/pimcore/blob/bc483848fba6f3c937676361d634ecedb9d0247c/tests/Model/Permissions/ModelDataObjectPermissionsTest.php#L713-L717 This user has 2 roles: https://github.com/pimcore/pimcore/blob/bc483848fba6f3c937676361d634ecedb9d0247c/tests/Model/Permissions/ModelDataObjectPermissionsTest.php#L280 https://github.com/pimcore/pimcore/blob/bc483848fba6f3c937676361d634ecedb9d0247c/tests/Model/Permissions/ModelDataObjectPermissionsTest.php#L222-L234 The roles allow and disallow `list` for same folder. Now the question is what shall happen? Current implementation...

Hmm, then `Service::findForbiddenPaths()` is wrong. This actually should only be a performance enhancement ticket - now it is about fixing broken permission logic... > No, at least only in the...

The problem still exists, also in 3.0 - do you know why you closed it, @dpfaffenbauer ? Because https://github.com/coreshop/CoreShop/pull/1896#pullrequestreview-982714728 can be easily fixed.

Have to look if I find a client who pays for further development... But perhaps you could also fix the remaining bug, @kingjia90 - I think we should not simply...

@kingjia90 This is still a big performance problem when there is a lot of data. Sadly current clients simply apply this PR via patching and are not willing to pay...

@fashxp Actually not. From our client projects it happens only in Pimcore 6.9 as far as I know - but this is only a gut feeling. And it mainly happens...