Blackbit

@dpfaffenbauer Currently https://github.com/coreshop/CoreShop/blob/master/features/domain/cart/rules/discount_amount_action_tax_rounding.feature fails. Actually I think this is because of the rounding errors but I cannot understand the test at all. When we have a 10 EUR voucher and...

OK, thank you for explanation. I think the net total price of 253,34 is wrong in above calculation (you calculated 304 / 1,2 but this is wrong because product voucher...

You calculated 304 / 1.2 in the first table in column `Price Net` in row `TOTAL`. Here 255,01 is correct (but does not matter) Except for this, the calculation in...

Exactly, both calculations are allowed but for products which are typically sold as whole items, we have to use tax from one item and multiply it by quantity. Only for...

Right. Seems that this is also what Magento does: https://mage2.pro/t/topic/1151

Have I missed something? I merged up-to-date 2.2 branch but it complains about missing database columns.

@nicolas-grekas > There's a related failure on Windows, see appveyor. Please add a test case also. Can you point me where the error occurs? Have bit of a problem interprerting...

@robertSt7 Done.

Thx @blankse, have applied the changes.

Completely right @jdreesen - have changed target branch. Thx.