Matteias Collet

Results 10 comments of Matteias Collet

For others stumbling on this issue, apparently - if applied via adblockers - the EasyPrivacy list prevents all `/heatmap.js` files from loading. Consider using a different name. ![image](https://user-images.githubusercontent.com/11077852/58557984-f656ee00-821f-11e9-924d-41f81dc61dde.png)

It's not an issue with your code rather than limitations of the Github API itself. Your query generally works fine, however, if you last contributed to a repository you don't...

Yes, it's certainly a huge effort to adjust the logic for this specific issue. I might get working on it myself if I find enough time to do so -...

> Remove the methods `skip`, `take` from query builder and implement them using JS `.slice` works for me. like it: > > ```ts > const entities = queryBuilder.getMany() > const...

+1 I was silly and assumed this already works out of the box when trying it out initially with one of my projects. Having to create and maintain a second...

Yes, but that wouldn't work in the browser (which only supports WebCrypto). And the libraries I looked at back then either only support ESM or CJS but not both, or...

> Pardon my ignorance, but what is the use case for signing URLs on the client? Why do any signing at all when the client has access to the secrets?...

Sorry for the late response. I think in this case it would be better to just not have an automatic fallback to the current implementation (ref https://github.com/BitPatty/imgproxy-url-builder/commit/a27eb972b05e9231e803418e08a999dc197f60ab#diff-02a29244b206e24420e4ab859666106afebd6339aecfd27f83275ae1418dc486R172). i.e. the signature...