Hugo Gruson

Results 313 comments of Hugo Gruson

> We have completed all of the tasks and addressed the comments, with the exception of adding tests, it's currently ~50% so we will probably need until the end of...

@jessicatytam, while investigating your problem, I had another look and I want to already now mention that @DrMattG's point about code duplication is not yet properly addressed in my opinion....

No, there is now an error in https://github.com/r-lib/lintr/blob/f6cf291a9b28b8c0bf88928aa5167b0396ad687d/R/namespace.R#L40 since `nrow(NULL)` is `NULL`

Well, now, I'm very confused :thinking: With #1506: ![image](https://user-images.githubusercontent.com/10783929/186612926-fdfd1b04-5e2a-4604-bc46-6074ebd9447e.png) With the version from `main` ![image](https://user-images.githubusercontent.com/10783929/186613201-9b5f40c1-e801-4211-ab8d-d3af21cc7ff1.png)

I think to reproduce, you need to install wpp2017. Otherwise, you'll end up on this branch and not reach the code causing the error. https://github.com/r-lib/lintr/blob/f6cf291a9b28b8c0bf88928aa5167b0396ad687d/R/namespace.R#L21-L23

We had a floating point precision issue that only shows up on CRAN checks with ATLAS. We tried to fix it by adjusting the tolerance in `expect_equal()` but we have...

But as far as I can tell, the transliteration feature of `iconv` leads to different outputs on different platforms, which is an issue in many cases.

Are you still interested in this? I can probably work on it in the next couple of weeks.

Not really but I'm interested enough in this feature to try and have a look at some point. I don't know anything about ggplot internals though so not sure I'll...