Birch-san

_disclaimer: my design patterns are based on Java experience, not Python._ I'd start by only implementing stuff that you actually have a user for. easy to add more later once...

hey, sorry for slow reply. okay, so this wrapper creates the illusion that the wrapped instance is a subtype of inner_model. seems reasonable (we want the wrapped instance to be...

okay sure, then yes: let's put a default implementation (identity function) of sigma_to_t() and t_to_sigma() in the base diffusion model wrapper.

this could help, in the case of Karras samplers at the default of `churn=0`: https://github.com/crowsonkb/k-diffusion/pull/30

regarding `user_random_data` API: I think a callback would be a more flexible API. so user passes in a `Callable[[int], Tensor]` — which lets the sampler ask for "the rand tensor...

amazing! definitely keen to try that out. what does "more stable" mean? do you mean that a wider variety of step counts (in particular lower step counts) will succeed in...

@crowsonkb outstanding work; I'll give it a try. another thing that's important for stable convergence is precision. Karras for example creates noise in float64: https://github.com/NVlabs/edm/blob/0a2ff34f0b80415ace7af7311074bd2255da0d1e/generate.py#L35 runs the model in its...

Wow, Brownian tree noise sampler makes convergence _way_ more stable! # `sample_dpmpp_2s_ancestral` 10, 15, 20, 25, 30, 35, 40, 100 steps ## Brownian noise ## Default noise 1 of my...

so with `sample_dpm_adaptive`… > make sure to pass in the Brownian tree first is Brownian, second is default: both ran for 51 iterations > decrease the per-step error tolerances atol...

if you're on a Typescript project: it can be because `.ts` is absent from the plugin's `extensions` config. error comes from here: https://github.com/tleunen/babel-plugin-module-resolver/blob/f2daf0678badccc78b4abede0ec4440df18338c2/src/resolvePath.js#L86 by default, extensions are just these: https://github.com/tleunen/babel-plugin-module-resolver/blob/f2daf0678badccc78b4abede0ec4440df18338c2/src/normalizeOptions.js#L11...