Somu Bhargava
Somu Bhargava
### What was wrong? Maybe it would be better if we had a `decorator` to convert key value pairs coming out in the form of `generators` or `dictionaries` to a...
### What was wrong? As part of the discussion [here](https://github.com/ethereum/py-evm/pull/1666#issuecomment-451587778), a new `Stack Benchmark` is needed. ### How was it fixed? A `TestStack.sol` contract was written which would serve as...
### What was wrong? As part of Issue #1656 ### How was it fixed? The `Stack` now stores only objects of type `int`. It previously also used to store `bytes`....
### What is wrong? As part of issue #1398 this new issue arised from this https://github.com/ethereum/py-evm/issues/1398#issuecomment-432303381. It was proposed to remove the different types of elements in the `stack` (`bytes`...
### What is wrong? There are many places in the code like, `finding an intersection of the tangent with the curve` etc. In other words, there are many functions whose...
### What is wrong? The first part of the upgrade is over, where the `fields` used by different curves were generalized into the `fields API`. Regarding the 2nd part of...
### What is wrong? This snippet of code here is a `class level variable` and it would be better to define it using a `metaclass`. https://github.com/ethereum/py_ecc/blob/b83b807e6ee058631e1904936c9795f913dfe342/py_ecc/fields/field_elements.py#L197-L201 ### How can it...
### What is wrong? Caching the outputs of the classmethods `one` and `zero` of the classes `FQ` and `FQP` **may** increase the performance It would ideally be better to do...
### What is wrong? Currently, the `FQ` and `FQP` fields have a lot of `isinstance` checks. This can be eradicated by making the classes subclasses of `int`. Reference Comment -...
### What is wrong? I personally think that it would be better if there were some `benchmarks` added to this library, so that to make sure that we are not...