Benjamin Piouffle

Results 889 comments of Benjamin Piouffle

There's already a partial with tests for linking a collective: https://github.com/opencollective/opencollective-api/blob/main/templates/partials/link-collective.hbs.

PayPal indeed provides better protection against these types of fraud than Stripe because they're supposed to show a captcha in the popup if your IP looks suspicious. But since they...

@hdiniz suggested in https://github.com/opencollective/opencollective-api/pull/7959 that we could have this approach for canceling the subscriptions only. That sounds like a good & simple MVP for this issue, as doing so won't...

New condition needs to be added here: https://github.com/opencollective/opencollective-frontend/blob/b14156e76c5d806716266b4cb9241ef12db2ede8/pages/expense.js#L690

@SudharakaP Well, "saving" and "submitting" are the same, just different words. The initial proposal was: > If no changes were made it should say 'submit' Calling a button "Submit" is...

There's a larger conversation about letting users customize their social sharing images (https://github.com/opencollective/opencollective/issues/2660), but here we could have picked their image from the collective page. Will push a hotfix.

Hi @Cadair! > 1. Why does the `"expense.comment.created"` payload have no data? What's the expected way to be able to provide links to the comment etc with that event? Expense...

Hi @nosro, need any help on that one? Happy to take it from here if you don't have the time :slightly_smiling_face:

Hi @lovell, thanks for the reference. Don't you think that would be a nice addition to `limax` core?

This change is required to add support for deprecated fields (see https://github.com/graphql/graphql-js/pull/2855). Would be great to have it merged, but I'm not sure if this package is still maintained?