Benjamin Piouffle

Results 889 comments of Benjamin Piouffle

On top of "Paid", it also doesn't make sense to allow `Mark it as incomplete` for: - Draft: drafts are, by nature, incomplete - Unverified: same as draft - Processing:...

Yes for this! We actually have a lot of data already recorded on the API side waiting to be displayed (eg. member invited, invitation accepted). By adding some complimentary events...

Feel free to look at https://github.com/opencollective/opencollective-api/blob/59a598b9d7d935cc4c52be388ae26ea24ca57309/server/graphql/v2/object/Expense.js#L321 for the implementation as the `Expenses` GQLV2 object supports returning its associated `Activities`.

Just discovered today that we don't log who made changes to the admin. Doing so sounds really important in itself and should probably be a requirement for this issue: https://github.com/opencollective/opencollective/issues/5519

We should try to implement this activity log with components as generic as possible. I can see us willing to exploit this feature in different places, for example: - A...

A question I did not see addressed in the specs: what to do with deleted accounts? Here, if Thomas Anderson has deleted his account, I still want to see the...

Use case: the other day @alinamanko rejected an expense by mistake, but was unable to find out which one and had to ask an engineer to look at the database....

Some personal concerns: - I don't see any use case for the public page, and there's a risk in letting anyone stalk the admin's activity (when do admins approve expenses?...

I wouldn't enforce lowercase on tags. I think it's a good experience that people are able to use things like `OSS` or `USA` (uppercase) if they want to. But I...

Isn't that what `Donation` payout method is for?