FogROS2
FogROS2 copied to clipboard
Python style and best practices
- [ ] Use python properties instead of
get_xfunctions- We have a lot of functions in aws.py that use
get_x(and corresponding calls toy.get_x()) for attributes that should be properties of the class. These should be changed to use the@propertydecorator and@x.setter(if not readonly).
- We have a lot of functions in aws.py that use
- [ ] All internal variables should be prefixed with
_(as in,self._x). - [ ] Abstract base classes should have separate files from their derived classes (e.g., AWS implementation of
CloudInstance) - [ ] Replace string concatenations using
+with f-strings - [ ] Replace
printwithloggingwhere possible
Check for Python Style guide/ checker