Bentsi Leviav comments

Results 35 comments of


                                            Bentsi Leviav

allows to add a comment in table's or view's metadata

Hi @dstsimokha Thank you so much for your contribution. Could you please resolve the conflicts in your branch?

Update table relation after exchange command

Sorry for the delay. I'll do my best to review it within the following days.

insert+replace partitions incremental strategy

@bryzgaloff Thanks again for your contribution! I would like to review your PR and merge it within the next few days. Can you sync your fork with the main repo?...

Resolve Change Relation Type error between Distributed and non-distributed Materializations

Hi @gfunc, Can we as a start, mitigate the changes only for distributed cases as @genzgd suggested? (and add a feature flag /config for the validation part?)

insert+replace partitions incremental strategy

Hi @bryzgaloff Huge thanks for this. I will review and update you within the next few days.

insert+replace partitions incremental strategy

Hi @bryzgaloff Sure, thank you for your contribution! Before merging this, could you please add to the doc that this feature is experimental, and wasn't tested with cluster setup? It...

insert+replace partitions incremental strategy

Never mind, I'll take care of it :)

Run Cloud tests against SMT

I created a [branch](https://github.com/ClickHouse/dbt-clickhouse/tree/cloud-tests-against-smt) with an additional GitHub job for testing against the SMT instance. There are still a few tests failures, due to a bug, will update here once...

Filter settings based on Engine

Hi @shachibista, Thank you for your contribution! I'm hesitant to move forward with this change as it introduces ongoing maintenance requirements. With this setup, every time ClickHouse adds new settings,...

Filter settings based on Engine

@genzgd suggested changing it from a white list to a black list (remove settings we identified as not relevant for this engine), and in case we face a new engine,...