Ben W.

Results 15 comments of Ben W.

Hi all! If this move away from using application config to setup Nostrum is still desired, I think I can take up this issue :) I have a couple of...

Ah okay. I'd love to help out with those rewrites if possible when the time comes!

I think this is indeed a bug. Placing a `.albertignore` file with content `node_modules` (no `/`s or `*`s) in a directory with many nested `node_modules` still indexes folders and files...

[This](https://github.com/albertlauncher/plugins/blob/master/files/src/indextreenode.cpp#L246-L248) seems to be the function/recursive call that handles the ignored paths. It looks like `localIgnoreEntries` is passed to the child nodes, too, so I'm not sure why nested file...

Hi, thanks for the review, I believe i've updated the docs + `mnesia_frag.erl` to your suggestions, and most of the highlighted coverage deficits. While making these changes, I noticed there's...

> Hi the patch you sent does not apply for me, you seem to have pushed commit to your branch today, could you send updated patch file? ah sorry, it...

Seems like an ephemeral error in CI? The mnesia check looks good on my [fork](https://github.com/Bentheburrito/otp/actions/runs/13828067722/job/38686828381)

> Hi @Bentheburrito are you planning on continuing this PR? Yes, just need to make time to address the rest of your comments

That makes sense, I also noticed this at some point and didn't mention it since it matches how ETS works. I'll look at removing `mnesia:select_reverse/1` in favor of `select/1` though....

> We only thought that you can get rid of implementation of select_reverse/1, and just do select_reverse(Cont) -> select(Cont). I wouldn't remove mnesia:select_reverse/1 function itself Thanks for clarifying, I misread...