Benjamin Rodenberg

Results 97 comments of Benjamin Rodenberg

@valentinaschueller: Feel free to take a look and give comments, if you want :grin:

* I decided to rename this tutorial, because we also call it the Oscillator example in the paper. It's also a shorter name. * I also added the final result...

> `initializeData()` contains an unconditional write mapping. Why? I think because the check `willDataBeExchanged` that we usually apply in `advance()` would always give us true in `initializeData()`. The question we...

Another note, if we want to add a check: I think we make our lives easier, if we put the check into `v3.0.0`. With the old `initialize` + `initializeData` API...

I think we should try to solve this issue before the next release, because currently we are struggling with the release of the python bindings that belongs to preCICE `v2.3.0`...

Related to this issue: my comments in https://github.com/precice/python-bindings/pull/149

We already have some instructions on building preCICE on windows with mingw in [our wiki](https://github.com/precice/precice/wiki/mingw-(Windows-version)).

In the python-bindings we use a limit of 120 columns (see https://github.com/precice/python-bindings/blob/8eee60710b786f9ae0bd6aeb5abc02b90c9f58e9/.github/workflows/check-pep8.yml#L18). According to PEP8 (python formatting rules) 80 columns are suggested, but since this comes from the time of...

> > Btw: Do we have a limit on actual code? Because the title of this issue only says "documentation / comments". I think it would make sense to make...

> I guess if we do this change we could simply remove `hasReadMapping()` and `hasWriteMapping()`. These functions seem to have no real purpose anymore. These functions are protected now. I...