Benjamin Rodenberg

Results 97 comments of Benjamin Rodenberg

This issue will be closed as soon as #1366 is merged.

After discussion with @uekerman: Let's keep this PR as it is for the moment. The change is definitely not a clear thing, but useful during the development on #1414 (it...

One important question that we will have to answer: Is a piecewise interpolation (zeroth order?) always used when subcycling is used? There are two possibilities: 1) User has to explicitly...

Another line of thought: What would a user search for when looking for this option? How can a user find this option in our documentation? Is there maybe already a...

Summary of important changes of today: * I'm using Eigen's BSpline interpolation for higher order. This needs a sufficient number of samples on the window. If there is an insufficient...

Next steps: 1. store write data every time when advance is called in some buffer in `CouplingScheme` or `CouplingData`. This will probably be another dict. 2. communicate this data to...

Steps 1 and 2 described above are now basically complete. Still needs some refactoring (probably could move the whole storing of time steps into an independent class and encapsulate components...

All tests are working now and subcycling is implemented :tada: Most todos are now on the code side, feature-wise it should be complete: - [x] Add some more tests to...

Summary of the current state: This PR should be synchronized with `develop-v3.0.0` and as focused on the actual feature as I can manage at the moment. Next step: I assume...

@uekerman: I assigned you hoping that you have an idea where this is coming from. I added it to the `2.x.x` milestone, because it seems to be acceleration related. If...