Benjamin Richner
Benjamin Richner
The error message is extremely confusing, and the fact that binary crates cannot be tested is unintuitive and guaranteed to confuse every single person who runs across this problem. Why...
> I'm exactly in that situation and I don't understand what I'm supposed to do. Have a `lib.rs` AND a `main.rs`? I don't get it. @EpiFouloux There is an alternative...
This bug breaks this crate completely for up to date Rust toolchains. @mxre would it be possible to accept PR #41 and publish the fix on crates.io? The crate _silently_...
> A temporary solution until the crate gets fixed would be to add @Nilstrieb's repo to Cargo.toml instead: > > `winres = { git = "https://github.com/Nilstrieb/winres", branch = "linking-flags" }`...
Hi @klsdfr , thank you for filing this bug and pull request. I don't quite understand the bug you are describing. Monsters cannot be on the same spot since they...
Ooh, I see it now. The crash happens when a monster tries to move out of bounds, I believe. Of course, array indices outside the boundaries, like `that.level_array[-1][0]` are not...
But I actually do perform boundary checks, so this bug is subtler, it somehow subverts my boundary checks.
Yeah that's nasty. There's a pretty big bug somewhere inside the `move` logic. It _seems_ airtight when I read the code, but somewhere in there, illegal moves are allowed. I...
The bug comes from the `is_small` property in the `walkable` check. There is insufficient checking done to prevent multiple monsters from walking into the same spot: https://github.com/BenjaminRi/Banania/blob/c3f54e3c50af6060c3936f87cec6174f0a858cca/game/game.js#L1311
The issue is fixed with commit a89488d602511ff8a775e6058b78102f3f6d3045 (currently HEAD of master) There was an issue with the logic that decided where entities (in particular, monsters) can move. However, the walkability...