Benjamin Bossan

Thanks for reporting. Could you please paste the full error message? Also, do you have a reproducer or are you using one of the examples from PEFT?

@stevhliu Thanks for the feedback, I added most of your suggestions. I'm not sure about the tables though. Using tables was also my first instinct, but what I dislike about...

@stevhliu I re-arranged the sections, is this what you had in mind? There are now subsections with identical names, not sure if this could be problematic.

Yes, I can reproduce the error. The reason is that since `transformers==4.40`, the `pre_classifier` module of this model is converted to a bitsandbytes `Linear4bit` when instead of being a normal...

> For compatibility, I could only use python 3.7, which only supports PEFT with version 0.3.0. Oh, too bad. You're probably aware, but just in case: Python 3.7 has been...

> Sorry for my untimely reply resulted by the time difference. No worries about that. > I generate `target_modules` by the following code. Do I understand correctly that you want...

Okay, so you mean the `save_range` part? Note that `target_modules` can be a string, in which case a `re.fullmatch` is performed. You can thus craft a regex pattern that matches...

That would also be fine if we're okay with the possible backwards incompatibility caused by the renaming (instead, we could leave the parameter name as is, but that's a bit...

There is no urgency, it would just be a convenient feature. The only reason to include it earlier rather than later is if we go with the proposal to rename...

Yes, it's easy too easy to miss currently. And even if you know that only supported keys should be used, you could still make a typo and there would be...