Benjamin Bossan

Results 584 comments of Benjamin Bossan

> he told me to create a method to add feature importance graphs. I can remove this and add it to model card example instead. If both of you agree...

> Would you like to wait for @adrinjalali to come back from his vacay to make a decision? If you can manage to remove the pandas dependency and if you...

Thanks for this PR. I have just skimmed it but in general think the changes are good. I'm not sure how the other maintainers feel about some of them, e.g....

@seanabreau Are you still working on this?

> convenience methods to convert scikit-learn fitted models to ONNX, and have easy ways to check if a model can be converted to ONNX I went through most of the...

Thanks a lot @anferico for taking this. I have only taken a quick look so far and noticed that you haven't added any unit tests for the changes. Could you...

Hey, no worries, take the time you need. I just asked because sometimes people just forget or are waiting on some input from the maintainers.

Yes, "cannot be loaded" unless the user says so. How granular do you want that to be, on a module level or should the user indicate individual functions?

> Since it doesn't make sense to load some functions and not load others Could you please elaborate on that? Do you mean that if a user would allow one...