skops icon indicating copy to clipboard operation
skops copied to clipboard

optimizations

Open seanabreau opened this issue 2 years ago • 2 comments

logical updates to make codebase more pythonic. updates pre commit hook so that isort complies with black formatting standards, preventing potential issues

seanabreau avatar Oct 14 '22 15:10 seanabreau

Thanks for this PR. I have just skimmed it but in general think the changes are good. I'm not sure how the other maintainers feel about some of them, e.g. the use of suppress, so I'd like to hear their opinion first.

The change regarding _extracted_from_save_29 should probably be reverted: This is a hot part of the code that'll probably change 5 times in the next month or so.

And just something for the future: This kind of change is appreciated but please open an issue first and quickly describe your intent. This way we can ensure that there is no wasted effort.

BenjaminBossan avatar Oct 14 '22 15:10 BenjaminBossan

sounds good I've reverted _extracted_from_save_29

Ok sorry about that going forward I'll create and issue or address an existing issue :)

seanabreau avatar Oct 15 '22 14:10 seanabreau

@seanabreau Are you still working on this?

BenjaminBossan avatar Nov 04 '22 11:11 BenjaminBossan

Closing due to inactivity.

adrinjalali avatar Nov 29 '22 15:11 adrinjalali