Benedikt Burger

Thanks for your comments. It's still a work in progress, but I wanted to get some ideas (mainly those in the questions section), therefore I opened the pull request. I...

The official adapters and the `Instrument` class are ready for review. Let us review the tests (mostly done), documentation (totally missing) and all the other instruments adjusted to these changes...

> I don't want to pull this into this PR to avoid increasing the already large scope even more, but if you have the time take a look how the...

> I'm wondering how this will mesh with VISAAdapter, which calls the pyvisa `write_binary_values` method. Can we just not use that (like we decided against the built-in ask/query) and do...

> Would you mind letting whoever opened a "conversation" item "resolve" the conversation? Of course I will adopt this workflow, I know what you mean. Do you do it generally...

Regarding `binary_values`: Statistics: One instrument uses `write_binary_values`, and three use `read_binary_values` and one uses pyvisa's `read_binary_values`. I looked at the implementation in the VISAAdapter: the used `np.fromstring` is deprecated in...

Thanks for your comment @msmttchr , enjoy your holidays. I agree, that it is sometimes necessary to transfer large parts of binary data. As I was not sure, that there...

> @bmoneke, please find a first set of comments for the adapter file. Thanks for your comments. I'm on vacation, so I'll respond later.

Regarding read/write_binary_values I face a difficult choice: Pyvisa's methods require knowledge of the term_chars. Here are some options how to implement it, what do you think is best? - `Instrument`...

I'm talking about how to implement read/write_**binary_values**. Right now, `SerialAdapter` has a very rudimentary approach. Some devices, however, invoke pyvisas `read_binary_values` in [pyvisa/resources/messagebased.py](https://github.com/pyvisa/pyvisa/blob/0029da29ea7c4adfe89c5fa6dd8a2021ab9e5ce4/pyvisa/resources/messagebased.py) which is more elaborate. I had proposed...