BenBE

Did one refactoring to remove some duplicate code. For reference, this is what (in the original patch), was the difference between these two routines: ```diff --- get_tracking_id 2024-12-12 16:29:12.119211606 +0100...

Somewhat mixed about this: Pro: + Reduce code complexity + Insecure anyway, thus no need to differentiate badness Con: - Limits informational/statistical usecases (e.g. key/algorithm tracking)

> > Limits informational/statistical usecases (e.g. key/algorithm tracking) > > Is there any real-world scenario where ssh-audit is being used to collect statistics on SSHv1 algorithms? I'd guess they are...

Or more easily, tag it and reference it in the README to the effectively same effect …

There has been some discussion about "custom commands" for htop, which would allow you to do exactly this via some configuration. Cf. e.g. #638. IIRC there was some more discussion...

> > Basic idea was reserving just one key and then to present the suer with a menu of possible actions > > Not sure about this, i really like...

The idea was more like having one key which brings up a menu to select the desired tool. Could still use some key assignment in that menu based on shortcuts.

The UID mapping should handle negative numbers if `uid_t` is signed.

Yes, the leak was possible. Have a really close look at the trace in the compiler warning from the referenced issue. I'd have to look at the previous state of...

Please have a very close look at your implementation again as I noticed several trivial buffer overflows in the file iteration/handling code. Furthermore I'd like to point you to our...